mbien commented on code in PR #8264:
URL: https://github.com/apache/netbeans/pull/8264#discussion_r1994650349
##########
java/lib.jshell.agent/build.xml:
##########
@@ -55,20 +55,6 @@
</target>
<target name="jar-probe" depends="probe-init">
- <unjar src="${agentsrc.jshell.cp}" dest="build/agent/classes">
- <patternset>
- <include name="jdk/jshell/execution/**"/>
- <exclude name="**/JDI*.class"/>
- <exclude name="**/LocalExecutionControl.class"/>
- <exclude name="**/StreamingExecutionControl.class"/>
- <!--<exclude name="**/DemultiplexInput.class"/>-->
- </patternset>
- <patternset>
- <include name="jdk/jshell/spi/ExecutionControl*.class"/>
- <exclude
name="jdk/jshell/spi/ExecutionControl*Generator.class"/>
- <include name="jdk/jshell/spi/SPIResolutionException.class"/>
- </patternset>
- </unjar>
Review Comment:
couldn't figure out why things like this existed so I looked through git
history. NB bundled jshell before it was part of JDK 9
https://github.com/emilianbold/netbeans-releases/blob/7c1a0f7ed55b753310aeff2d1fbb45e996ebb7b1/libs.jshell/src/org/netbeans/libs/jshell/Bundle.properties#L44
But what remained of it is that
https://netbeans.osuosl.org/binaries/1CA9DE21C6E443E814CB56912BEE872EF7094C49-jshell-9.jar
is used to build the agent against, so removing it is fine since it is all in
the JDK now, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
