mbien commented on code in PR #8264:
URL: https://github.com/apache/netbeans/pull/8264#discussion_r2020262683
##########
java/lib.jshell.agent/build.xml:
##########
@@ -55,20 +55,6 @@
</target>
<target name="jar-probe" depends="probe-init">
- <unjar src="${agentsrc.jshell.cp}" dest="build/agent/classes">
- <patternset>
- <include name="jdk/jshell/execution/**"/>
- <exclude name="**/JDI*.class"/>
- <exclude name="**/LocalExecutionControl.class"/>
- <exclude name="**/StreamingExecutionControl.class"/>
- <!--<exclude name="**/DemultiplexInput.class"/>-->
- </patternset>
- <patternset>
- <include name="jdk/jshell/spi/ExecutionControl*.class"/>
- <exclude
name="jdk/jshell/spi/ExecutionControl*Generator.class"/>
- <include name="jdk/jshell/spi/SPIResolutionException.class"/>
- </patternset>
- </unjar>
Review Comment:
current version has now `nb-mod-jshell-probe.jar` and references to it
removed. Still not sure what approach to take but there is no rush.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
