jtulach commented on code in PR #8725:
URL: https://github.com/apache/netbeans/pull/8725#discussion_r2295966792
##########
platform/o.n.bootstrap/launcher/unix/nbexec:
##########
@@ -157,16 +157,22 @@ if [ -z "$jdkhome" ] ; then
jdkhome="/Library/Internet
Plug-Ins/JavaAppletPlugin.plugin/Contents/Home"
fi
;;
- *) javac=`which javac`
- if [ -z "$javac" ] ; then
- java=`which java`
- if [ ! -z "$java" ] ; then
- java=`resolve_symlink "$java"`
- jdkhome=`dirname $java`"/.."
- fi
+ *)
+ if [ ! -z "${JAVA_HOME}" ]; then
Review Comment:
- this code reads the `JAVA_HOME` environment variable
- the #8756 PR does something similar for `--userdir`, but it also
- sets the environment variable
- so child processes find the same value even if it was only specified by
CLI argument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
