stoty commented on code in PR #8725:
URL: https://github.com/apache/netbeans/pull/8725#discussion_r2297072665
##########
platform/o.n.bootstrap/launcher/unix/nbexec:
##########
@@ -157,16 +157,22 @@ if [ -z "$jdkhome" ] ; then
jdkhome="/Library/Internet
Plug-Ins/JavaAppletPlugin.plugin/Contents/Home"
fi
;;
- *) javac=`which javac`
- if [ -z "$javac" ] ; then
- java=`which java`
- if [ ! -z "$java" ] ; then
- java=`resolve_symlink "$java"`
- jdkhome=`dirname $java`"/.."
- fi
+ *)
+ if [ ! -z "${JAVA_HOME}" ]; then
Review Comment:
I don't know enough about how NetBeans handles multiple Java enviroments to
comment on whether that's a good idea.
In some IDEs the Java that runs the IDE is independent from the Java(s) used
for the projects.
IMO such a change would better be done from the Java side, as this patch
only touches the non-Apple Unix path, and the java code would be a common path
instead of threeseparate ones (MacOS, generic unix, Windows)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
