neilcsmith-net opened a new pull request, #8799: URL: https://github.com/apache/netbeans/pull/8799
Removes use of deprecated Integer constructors for NotifyDescriptor constants. Alternative to #8407 for testing and discussion. This change keeps the existing value relationship with JOptionPane int constants, which involves managing `YES` and `OK` now having the same identity. It is no longer possible to maintain both aspects, just choose the one that offers best compatibility. Various usages in the NetBeans codebase suggest that keeping the values might lead to less hidden issues in our and third-party usage. eg. https://github.com/apache/netbeans/blob/2c9230058bf194fe6ce05a01518b4143a16624ba/php/php.dbgp/src/org/netbeans/modules/php/dbgp/ServerThread.java#L113 or https://github.com/apache/netbeans/blob/2c9230058bf194fe6ce05a01518b4143a16624ba/php/php.smarty/src/org/netbeans/modules/php/smarty/editor/TplEditorSupport.java#L137 There's a mix in code that checks return values by equals and by identity. Having these work the same might be desirable. The key place that not being able to differentiate `OK` and `YES` might cause problems is in the specification of custom options. The API does not actually say `YES` is a valid argument, but that is currently supported in the main implementation. This change assumes `YES` is wanted if `NO` is also present. Return values should work as before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
