neilcsmith-net commented on PR #8799: URL: https://github.com/apache/netbeans/pull/8799#issuecomment-3270785293
Marking ready for review but do not merge. This would be my preferred option to #8407 for handling the necessary changes for `NotifyDescriptor` options with upcoming value type changes. Both options keep to the API definition. Both options could break usage relying on implementation details (eg. linked code above). This one seems safer to me. The test change is required because it will no longer be possible to specify both `OK` and `YES` in custom options. Hopefully people are not actually doing something so strange in real-world usage! It's also an implementation detail as `YES` and `NO` are not included in the range of supported options here [documented in the spec](https://bits.netbeans.org/27/javadoc/org-openide-dialogs/org/openide/DialogDescriptor.html#%3Cinit%3E(java.lang.Object,java.lang.String,boolean,java.lang.Object%5B%5D,java.lang.Object,int,org.openide.util.HelpCtx,java.awt.event.ActionListener)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
