matthiasblaesing commented on code in PR #8756:
URL: https://github.com/apache/netbeans/pull/8756#discussion_r2407887323
##########
nb/o.n.upgrader/arch.xml:
##########
@@ -621,6 +621,43 @@
clusters' fully qualified paths separated by path.separator (semicolon
on Windows, colon on Unices)
</api></li>
</ul>
+ <p>
+ When the <code>netbeans</code> launcher starts, it also manipulates
+ (reads and writes) following properties:
+ </p>
+ <ul>
+ <li><api name="NETBEANS_USERDIR" category="devel" group="property"
type="export">
+ <p>
+ If this <em>environment variable</em> is set to a valid value,
+ then its value is used as default user dir
+ instead of <code>netbeans_default_userdir</code> read from
+ the config file.
+ </p>
+ <p>
+ When the value of user dir is finally determined by the launcher
+ (by considering default values, value of this environment variable
+ and <code>--userdir</code> CLI switch, etc.) the launcher sets
+ <code>NETBEANS_USERDIR</code> environment variable for itself
+ and its subprocesses.
+ </p>
+ <p>
+ That way executing <code>netbeans</code> in the NetBeans internal
+ terminal will know what's the userdir of the surrouding NetBeans
+ and will open files in the same instance just as
+ <a href="https://github.com/apache/netbeans/pull/8756";>#8756
illustrates</a>.
+ </p>
+ <p>
+ The launcher also modifies the <code>PATH</code> variable
Review Comment:
Should this be split of into its own listitem?
##########
nb/ide.launcher/unix/netbeans:
##########
@@ -65,8 +65,17 @@ fi
export DEFAULT_USERDIR_ROOT
+if ! [ "$NETBEANS_USERDIR" = "nope" ]; then
Review Comment:
When reading this I was thinking "What is the meaning of this?". And the
only explanation I could find was slang for "no". If that is the case, I would
advice against it. I think "IGNORE", "DISABLED" or something similar, more
formal would be clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
