matthiasblaesing commented on code in PR #8756:
URL: https://github.com/apache/netbeans/pull/8756#discussion_r2429973552


##########
nb/ide.launcher/unix/netbeans:
##########
@@ -38,12 +38,18 @@ cd "$progdir"/..
 basedir=`pwd`
 cd "$old"
 
-case "`uname`" in
+case "`uname -s -m`" in
     Darwin*)
         # set default userdir and cachedir on Mac OS X
         DEFAULT_USERDIR_ROOT="${HOME}/Library/Application Support/NetBeans"
         DEFAULT_CACHEDIR_ROOT=${HOME}/Library/Caches/NetBeans
         ;;
+    CYGWIN*_64)
+        exec "$progdir/netbeans64.exe" $*
+        ;;
+    CYGWIN*)
+        exec "$progdir/netbeans.exe" $*
+        ;;

Review Comment:
   Thanks for the update. The idea to bridge to the exe file from the shell 
launcher is nice. The quoting of the binary path works, but the parameter is 
still problematic:
   
   <img width="624" height="423" alt="grafik" 
src="https://github.com/user-attachments/assets/8af15c53-fa50-40f0-aba6-3e904dc3ba4c";
 />
   
   Looking at the remainder of the file, a different parameter format works 
fine for me:
   
   
   ```suggestion
       CYGWIN*_64)
           exec "$progdir/netbeans64.exe" "$@"
           ;;
       CYGWIN*)
           exec "$progdir/netbeans.exe" "$@"
           ;;
   ```
   
   <img width="459" height="151" alt="Image" 
src="https://github.com/user-attachments/assets/aea8a1af-13e1-461e-83fd-82a6073dbbab";
 />
   
   The result (here tested with two files, one with space in path, one just to 
test two parameters):
   
   <img width="688" height="541" alt="Image" 
src="https://github.com/user-attachments/assets/f5ac272d-b3e0-4503-8426-750fb2aeb54b";
 />
   
   Both files are opened fine.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to