Chris2011 opened a new pull request, #8922:
URL: https://github.com/apache/netbeans/pull/8922

   If you have add more than one remote and you want to push an untracked 
branch, NetBeans just shows an error that it can't choose the correct remote 
due to many remotes.
   
   I added this for push to upstream and pull from upstream. If we have 
multiple remotes, it just opens the same UI for pull/push and preselect the 
current branch.
   
   For push it will also ask for setting this branch tracked to the remote 
branch. I have a problem for doing the same for pull. I guess it is a thread 
thing.
   
   Inside of PullAction in the method perform, it never hits the finally block, 
due to removing the threadlocal variable inside the runWithoutInding method. I 
dunno whether this is a bug but for me it feels like that. So I couldn't test 
it.
   
   The PR is not finished yet, but you already can have a look and left 
comments please.
   
   
   ### PR approval and merge checklist:
   
   1. [ ] Was this PR [correctly 
labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)),
 did the right tests run? When did they run?
   2. [ ] Is this PR 
[squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
   3. [ ] Are author name / email address correct? Are 
[co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line)
 correctly listed? Do the commit messages need updates?
   3. [ ] Does the PR title and description still fit after the Nth iteration? 
Is the description sufficient to appear in the release notes?
   
   If this PR targets the delivery branch: [don't 
merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery).
 ([full wiki 
article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to