matthiasblaesing commented on code in PR #8922:
URL: https://github.com/apache/netbeans/pull/8922#discussion_r2652702518
##########
ide/git/src/org/netbeans/modules/git/ui/fetch/PullBranchesStep.java:
##########
@@ -129,7 +129,11 @@ public void setRemote (GitRemoteConfig remote) {
}
public void fillRemoteBranches (final Map<String, GitBranch> branches) {
- fillRemoteBranches(Collections.<String,GitBranch>emptyMap(),
Collections.<String,GitBranch>emptyMap());
+ fillRemoteBranches(branches, null);
+ }
+
+ public void fillRemoteBranches (final Map<String, GitBranch> branches,
final GitBranch branchToSelect) {
+ fillRemoteBranchesInternal(Collections.<String,GitBranch>emptyMap(),
Collections.<String,GitBranch>emptyMap(), null);
Review Comment:
Sorry, I don't get it. line 169-173 can't be reached for the marked case. I
mean this call:
```java
fillRemoteBranchesInternal(Collections.<String,GitBranch>emptyMap(),
Collections.<String,GitBranch>emptyMap(), null);
```
This will basicly execute (the maps are empty, so all loops in
`fillRemoteBranchesInternal` will not execute):
```java
List<BranchMapping> l = new ArrayList<BranchMapping>(0);
Set<String> displayedBranches = new HashSet<String>(0);
this.branches.setBranches(l);
stateChanged(new ChangeEvent(this));
```
I read this as "reset the item selector into a clean state".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
