mbien commented on PR #9209: URL: https://github.com/apache/netbeans/pull/9209#issuecomment-3910634007
> In which case I don't get it. You're using a theme, like me, where this indicator is the accent colour, the window drop indicator used to be hardcoded as signal color (some red/orange tone: 255, 90, 0) as long I remember using NB. It used to be a basic stroke, I changed it to dashed lines to indicate that it is a dock point (dashes often indicate cut/paste/drop targets) for NB 28. Dashes make signal colors less signally since they reduce the number of painted pixels which was a side effect of the change. What I was saying is that I am using a theme similar to FlatLaf Dark. Similar accent color of flatlaf dark. (no my accent color is not orange). While testing PRs, I am sticking to default themes since that is what a user would see most likely. > I've made the colour tones derive from the accent, but different for light and dark. And I've put the stroke weight back, but left it configurable. Making it configurable via the properties is great. But changing a color which used to be a signal color (signal colors contrast with everything, like red for errors) to an accent color which is used everywhere will likely need some testing. I haven't really played with this much but my guess is that changing it back to the equivalent of `BasicStroke(3)` will likely look better with the default blue accent color and will stand out a little more when multiple shades of the same accent colors overlap. It also seems to use some alpha blending depending on the drop target (alpha increases if the drop would change a view into an editor or vise versa) - never noticed it so far - wondering if this is an effective way to communicate mode mixing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
