neilcsmith-net commented on PR #9209: URL: https://github.com/apache/netbeans/pull/9209#issuecomment-3914053731
Updated screenshot - back to 3pt, and now a darker (or lighter on dark laf) variant of the accent colour rather than the same. <img width="854" height="814" alt="Screenshot from 2026-02-17 10-50-13" src="https://github.com/user-attachments/assets/fc8f1b34-259f-4e22-bc9f-5d4bb0b852f7"; /> > What I was saying is that I am using a theme similar to FlatLaf Dark. Similar accent color of flatlaf dark. (no my accent color is not orange). While testing PRs, I am sticking to default themes since that is what a user would see most likely. OK, I was misunderstanding what you were getting at. I also always check dev builds and PRs with the default colours for that reason. Any colour change I also check with all provided accents. However, I run my main IDE with orange - mainly so it's easier to tell which is the right IDE to type in! :smile: Maybe because I don't drag windows much, I think I'd assumed this was accent derived already. I've certainly never thought it didn't stand out enough when close to accent colour. Or really thought about how ugly the default is until Chris mentioned it! > But changing a color which used to be a signal color (signal colors contrast with everything, like red for errors) to an accent color which is used everywhere will likely need some testing. I disagree with you that this is a signal colour, or semantic colour, which is what you suggest with red for errors. If this was semantic, it's giving the wrong message - would probably be better green, with amber for the view / editor mismatch. The current warning isn't alpha blending btw, it's a cross-hatch paint. This colour possibly linked in well with look and feels with fixed dual accent colours - Nimbus is blue with orange IIRC. But we don't at the moment have secondary accent colours in FlatLaf as far as I know. If you feel we need one (I don't) we could generate from the primary. But it should not be something fixed or it no longer guarantees contrast when people change the accent. Funny how the tiniest visual changes generate the most discussion! :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
