jtulach commented on PR #9383: URL: https://github.com/apache/netbeans/pull/9383#issuecomment-4389739212
- @matthiasblaesing [suggested to remove](https://github.com/JaroslavTulach/nb-javac/pull/39#issuecomment-4379575968) the `canUseRelease` code altogether - I would rather fix the code to honor `canUseRelease` everywhere as this PR does - using `--release` is preferred over `--source` and `--target` in my opinion - the `--release` exposes only official Java API - when nb-javac build of NetBeans succeeds, we are then sure that regular modules don't use `sun.misc.Unsafe` & co. ... - ... which was a typical problem before I implemented this _replace source and target by release_ when possible check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
