jtulach commented on PR #9383: URL: https://github.com/apache/netbeans/pull/9383#issuecomment-4411838795
> Looks sane to me and can IMHO be merged to master, not delivery. I don't see a reason to interfere with release for this. OK, targeting `master`. We are still green. > Independent from that I disagree with the assessment, that having the magic `--target == --source maps to --release` in there is a good idea. Many modules are already are correctly configured in their properties, to use `javac.release`, Yeah, using `javac.release` where possible is certainly better and less magical than the current "switch"... > We can cleanup later when we stop using javac.source in NB. ...but as Jan wrote. Let that happen in other PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
