matthiasblaesing commented on code in PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#discussion_r3284083815
##########
platform/o.apache.commons.lang3/build.xml:
##########
@@ -21,5 +21,19 @@
-->
<project name="platform/o.apache.commons.lang3" default="build" basedir=".">
<import file="../../nbbuild/templates/projectized.xml"/>
- <target name="jar"/>
+ <!--
+ The NetBeans module org.apache.commons.lang3 is just a repackaging
+ of the original bundle, with problematic elements relating to OSGI
+ and Netbinox replaced in the MANIFEST.
+ -->
Review Comment:
_What_ is problematic?
##########
platform/libs.testng/nbproject/project.xml:
##########
@@ -37,12 +37,20 @@
<package>org.testng.xml</package>
</public-packages>
<class-path-extension>
-
<runtime-relative-path>ext/testng-6.14.3.jar</runtime-relative-path>
- <binary-origin>external/testng-6.14.3.jar</binary-origin>
+
<runtime-relative-path>ext/testng-7.11.0.jar</runtime-relative-path>
+ <binary-origin>external/testng-7.11.0.jar</binary-origin>
</class-path-extension>
<class-path-extension>
-
<runtime-relative-path>ext/jcommander-1.78.jar</runtime-relative-path>
- <binary-origin>external/jcommander-1.78.jar</binary-origin>
+
<runtime-relative-path>ext/jcommander-1.85.jar</runtime-relative-path>
+ <binary-origin>external/jcommander-1.85.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+
<runtime-relative-path>ext/testng-ant-1.0.0.jar</runtime-relative-path>
+ <binary-origin>external/testng-ant-1.0.0.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+
<runtime-relative-path>ext/slf4j-api-2.0.17.jar</runtime-relative-path>
+ <binary-origin>external/slf4j-api-2.0.17.jar</binary-origin>
</class-path-extension>
Review Comment:
Is this needed? We have `slf4j-api` as a module. Do we need to update that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
