sid-srini commented on code in PR #9254:
URL: https://github.com/apache/netbeans/pull/9254#discussion_r3330190668
##########
platform/libs.testng/nbproject/project.xml:
##########
@@ -37,12 +37,20 @@
<package>org.testng.xml</package>
</public-packages>
<class-path-extension>
-
<runtime-relative-path>ext/testng-6.14.3.jar</runtime-relative-path>
- <binary-origin>external/testng-6.14.3.jar</binary-origin>
+
<runtime-relative-path>ext/testng-7.11.0.jar</runtime-relative-path>
+ <binary-origin>external/testng-7.11.0.jar</binary-origin>
</class-path-extension>
<class-path-extension>
-
<runtime-relative-path>ext/jcommander-1.78.jar</runtime-relative-path>
- <binary-origin>external/jcommander-1.78.jar</binary-origin>
+
<runtime-relative-path>ext/jcommander-1.85.jar</runtime-relative-path>
+ <binary-origin>external/jcommander-1.85.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+
<runtime-relative-path>ext/testng-ant-1.0.0.jar</runtime-relative-path>
+ <binary-origin>external/testng-ant-1.0.0.jar</binary-origin>
+ </class-path-extension>
+ <class-path-extension>
+
<runtime-relative-path>ext/slf4j-api-2.0.17.jar</runtime-relative-path>
+ <binary-origin>external/slf4j-api-2.0.17.jar</binary-origin>
</class-path-extension>
Review Comment:
The `ide/slf4j-api` module provides v1 of slf4j whereas the newer testng
references v2. Since the v1 module is used in some other unrelated modules, it
would perhaps be better to include the necessary v2 api in this module itself.
Further, since testng is in the `platform` cluster, I would imagine that the
isolation from the `ide` cluster would be beneficial for build tasks. The maven
module also seems to keep its own copy of the slf4j-api perhaps in order to
isolate itself from the global `ide` slf4j module.
Please let me know what you think. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
