tmysik commented on code in PR #9431:
URL: https://github.com/apache/netbeans/pull/9431#discussion_r3388571904
##########
php/php.api.phpmodule/src/org/netbeans/modules/php/api/PhpVersion.java:
##########
@@ -245,6 +245,17 @@ public boolean hasMixedType() {
return this.compareTo(PhpVersion.PHP_80) >= 0;
}
+ /**
+ * Check whether this version supports the static return type. (as of PHP
8.0)
+ *
+ * @return {@code true} if this version supports static return type,
+ * {@code false} otherwise
+ * @since check code
+ */
+ public boolean hasStaticReturnType() {
Review Comment:
Understood, as I wrote, whatever works now, I am fine with that.
_One note:_ as you write, increasing does not harm (nobody cares whether the
plugin version is 1.5 or 1.247) and to explain why why we did it even during
the development - if somebody uses a daily build of NetBeans, not doing this
change can break it (`NoSuchMethodError`, typically). If you do proper API
versioning, both the modules will be ready to update. Of course, a workaround
is simple - just download a fresh dev build of NetBeans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
