tmysik commented on code in PR #9431:
URL: https://github.com/apache/netbeans/pull/9431#discussion_r3411996460
##########
php/php.editor/src/org/netbeans/modules/php/editor/codegen/SinglePropertyMethodCreator.java:
##########
@@ -191,6 +191,9 @@ public String create(Property property) {
}
private String getReturnType() {
+ if (cgsInfo.isFluentSetter() &&
cgsInfo.getPhpVersion().hasStaticReturnType()) {
Review Comment:
Well, this was already discussed with @neilcsmith-net and currently, we
don't version our APIs on every change (basically, no API version change in the
development cycle). So, what _exact_ version should be set in the Javadoc, I
don't know. Neil, could you advise, please? Perhaps the current version + 1?
@DamImpr how this is supposed to work if we version every API change:
- update/change the code of the API module (`php.api.phpmodule` here)
- because of this change, increase the specification version of this module
(e.g. `3.107 -> 3.108`)
- you want to use this newly added code in the PHP editor, so
- update the dependency version in `php.editor` module to the latest one:
`3.108`
- now, the newly added code is _visible_ also in the PHP editor
Hopefully, it is more clear now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
