renatsaf commented on PR #9445: URL: https://github.com/apache/netbeans/pull/9445#issuecomment-4758507404
You're both right — thanks for actually testing. I'd wrongly assumed the empty dropdown was purely a config/enum sync gap; I hadn't verified that GlassFish itself boots on JDK 26, and it doesn't (the asm OSGi `osgi.ee=JavaSE;version=1.5.0` resolution failure @mbien pasted). Advertising 26/27 in the NetBeans config would just trade the empty-dropdown bug for a worse "server dies at startup with a cryptic OSGi trace" bug. So I've dropped the 26/27 additions (and the `v27` enum constant) and force-pushed. To still close #9423, I reworked the PR to fix the dialog itself: when no installed JDK matches the server's supported range, the panel now shows a message naming the supported range and pointing at **Manage Platforms**, instead of an empty combo with only Cancel. That fixes the reported UX without misrepresenting GlassFish's JDK support. Once a GlassFish release genuinely boots on 26, bumping the config is a one-liner. I did not build NetBeans locally for this change, so a quick check of the dialog wording on your side would be appreciated. (Also still watching the dev-list thread on LLM-assisted contributions — happy to adjust presentation based on where that lands.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
