mbien commented on PR #9445: URL: https://github.com/apache/netbeans/pull/9445#issuecomment-4970627665
tested this a bit and it works, at some point we would have to consolidate this with the server config window since it has very similar UI. (ideally without duplicating code) I think we should also consider changing the logic, since glassfish still leaves the experimental support for newer JDKs open ended. It may or may not work and can change from one point release to another. https://glassfish.org/docs/7.1.1/release-notes.html#required-jdk-versions https://glassfish.org/docs/8.0.3/release-notes.html#required-jdk-versions e.g `Eclipse GlassFish Release 8 requires Java 21 minimum and runs on JDK 21 to JDK 25, with experimental support for higher versions.` IMO we should let the user run it by not checking the upper bound, if it fails it fails. We can't keep up with the releases anyway. cc @pepness but lets get this in, @renatsaf thanks for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
