[
https://issues.apache.org/jira/browse/OFBIZ-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059468#comment-16059468
]
Jacques Le Roux commented on OFBIZ-9392:
----------------------------------------
Hi Taher,
Thanks for your patience. I finally found a continuous hour+ to review your
patch. I like it, notably the use of streams and lambdas. And the the class is
much easier to read now. This patch is hard to review (much lines moved) so I'd
not say that I could not have missed anything but I checked many points. Good
catch on FilterDef. Of course tests and running OFBiz are fine.
I'd though still need to be used to things like
{code}
- for (Map.Entry<String, String> entry: initParameters.entrySet()) {
- context.addParameter(entry.getKey(), entry.getValue());
- }
+ initParameters.entrySet().forEach(entry ->
context.addParameter(entry.getKey(), entry.getValue()));
{code}
But after all syntax sugar is only that and it somehow compares to with Groovy
way.
+1 for commit.
> Refactor CatalinaContainer
> --------------------------
>
> Key: OFBIZ-9392
> URL: https://issues.apache.org/jira/browse/OFBIZ-9392
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Priority: Minor
> Attachments: OFBIZ-9392.patch, OFBIZ-9392.patch, OFBIZ-9392.patch,
> OFBIZ-9392.patch
>
>
> The implementation of CatalinaContainer.java is currently very verbose, has
> replicated code, and is difficult to navigate.
> The objective of this JIRA is to breakup the logic into smaller manageable
> functions to allow for further enhancements in the future.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
