[
https://issues.apache.org/jira/browse/OFBIZ-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061399#comment-16061399
]
Michael Brohl commented on OFBIZ-9392:
--------------------------------------
Hi [~taher],
wow, great work, thank you very much! Readability improved a lot!
I have read the code, run the tests and checked OFBiz works fine. I haven't
checked the clustering functionality because I didn't have the time to setup a
clustering environment to really test it. From the code, everything looks fine
to me.
Thanks and regards,
Michael
Just one minor note: we currently set
{code:java}
context.setJ2EEServer("OFBiz Container 3.1");
{code}
I guess the "3.1" comes from ancient times and think we should remove it. It
doesn't hurt because it seems only to be displayed in the JMX context but it
looks strange.
+1 for committing it to the codebase.
> Refactor CatalinaContainer
> --------------------------
>
> Key: OFBIZ-9392
> URL: https://issues.apache.org/jira/browse/OFBIZ-9392
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Priority: Minor
> Attachments: OFBIZ-9392.patch, OFBIZ-9392.patch, OFBIZ-9392.patch,
> OFBIZ-9392.patch
>
>
> The implementation of CatalinaContainer.java is currently very verbose, has
> replicated code, and is difficult to navigate.
> The objective of this JIRA is to breakup the logic into smaller manageable
> functions to allow for further enhancements in the future.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
