[
https://issues.apache.org/jira/browse/OFBIZ-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472975#comment-16472975
]
Deepak Dixit commented on OFBIZ-10398:
--------------------------------------
Thanks Pierre,
I think we can convert expirePartyContactMechPurpose service to entity-auto,
and can use partyIdPermissionCheck as permission service.
Also as we are renaming service so why not think to remove ifExists as suffix
from service name and use expirePartyContactMechPurposes or much better name.
> Rename deletePartyContactMechPurpose* services
> ----------------------------------------------
>
> Key: OFBIZ-10398
> URL: https://issues.apache.org/jira/browse/OFBIZ-10398
> Project: OFBiz
> Issue Type: Improvement
> Components: order, party
> Affects Versions: Trunk
> Reporter: Pierre Smits
> Assignee: Pierre Smits
> Priority: Major
> Attachments: OFBIZ-10398-rename.patch
>
>
> Both deletePartyContactMechPurposeIfExists and deletePartyContactMechPurpose
> are misnomers, as these functions don't delete records but expires those by
> setting the thruDate. The misnomers creates unnecessary confusion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
