[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895978#comment-16895978
 ] 

Jacopo Cappellato commented on OFBIZ-10145:
-------------------------------------------

In preparation for the publication of a new release from 16.11 I have prepared 
a patch that I would like to commit to the release branch 16.11 that provides 
instructions to the end user for downloading Gradle and preparing the Gradle 
wrapper.

Please test it and let me know if it looks like the right approach (this is 
essentially what we have discussed in the dev mailing list).

In order to test:
 # remove the following files (these will be removed from the release package):
 ## gradle/wrapper/gradle-wrapper.jar
 ## gradle/wrapper/gradle-wrapper.properties
 ## gradlew
 ## gradlew.bat
 # apply the patch release-16.11-without-gradlew.patch
 # follow the new instructions added to the section "System requirements" of 
the README file

Thank you

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10145
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10145
>             Project: OFBiz
>          Issue Type: Task
>          Components: Gradle
>    Affects Versions: 17.12.01, 16.11.06, 18.12.01
>            Reporter: Jacques Le Roux
>            Assignee: Nicolas Malin
>            Priority: Blocker
>             Fix For: 17.12.01
>
>         Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, 
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.bat, 
> init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, 
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to