[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896189#comment-16896189
 ] 

Jacques Le Roux commented on OFBIZ-10145:
-----------------------------------------

Hi Jacopo,

[As proposed 
Nicolas|https://lists.apache.org/thread.html/54a5fa80f9b0e4186498f76b62a9d6adc9fd23e8a350fa2e1c702f83@%3Cdev.ofbiz.apache.org%3E]:
{quote}I'm in favor to keep an init-gradle-wrapper to help first discovery 
without complex preparation and the script maintenance is really easy.

So we can have on documentation advisable part with install gradle from 
official source and other part for unfamiliar people with quick start through 
init-gradle-wrapper.
{quote}
I suggest we put the last init-gradle-wrapper scripts (both *nix and Windows) 
in OFBIz root, to allow and easy UX. Though I believe init-gradle-wrapper.sh 
should be simplified as is the init-gradle-wrapper.bat is to catch with the 
README.MD content where I'd use
{quote}[Installing Gradle 
manually]([https://docs.gradle.org/current/userguide/installation.html])
 Alternatively you might run the init-gradle-wrapper script (either *nix or 
Windows).
{quote}
I have updated [^release-16.11-without-gradlew.patch] for that.

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10145
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10145
>             Project: OFBiz
>          Issue Type: Task
>          Components: Gradle
>    Affects Versions: 17.12.01, 16.11.06, 18.12.01
>            Reporter: Jacques Le Roux
>            Assignee: Nicolas Malin
>            Priority: Blocker
>             Fix For: 17.12.01
>
>         Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, 
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.bat, 
> init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, 
> init-gradlew-readme.patch, release-16.11-without-gradlew.patch, 
> release-16.11-without-gradlew.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to