[
https://issues.apache.org/jira/browse/OFBIZ-11431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049195#comment-17049195
]
Pierre Smits commented on OFBIZ-11431:
--------------------------------------
Simply following your suggestion does not lead to correct use of the field.
People often overlook comments in tickets and elsewhere.
A data model change is what you get when wrong (ambiguous) definitions appear
in the model. Leaving wrong approaches in does not help adopters, nor the
project. Rather sticking to conventions used elsewhere in the codebase
regarding the *UomId definitions would be better for the project.
> InvoiceItem: uomID is wrongly defined
> -------------------------------------
>
> Key: OFBIZ-11431
> URL: https://issues.apache.org/jira/browse/OFBIZ-11431
> Project: OFBiz
> Issue Type: Bug
> Components: datamodel
> Affects Versions: Trunk
> Reporter: Pierre Smits
> Priority: Critical
> Labels: refactoring
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the InvoiceItem entity has the field uomId, per:
> {code:java}
> <field name="uomId" type="id"></field>
> {code}
> per the demo data this field is used to capture the currency of the invoice
> item. This is, however, wrong. The currency for invoice items is set in the
> invoice entity record (with field currencyUomId.
> The uomId in the invoice item is related to the quantity set, and must be
> correctly named: 'quantityUomId.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
