[ 
https://issues.apache.org/jira/browse/OFBIZ-11431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073423#comment-17073423
 ] 

Michael Brohl commented on OFBIZ-11431:
---------------------------------------

I don't see the renaming of the field as crucial for new users as described. 
With a proper documented field they will clearly know how to use it.

On the other side, it forces all existing users to do a database migration of 
their productive systems which has way more effects. IMO the project has to 
provide a deprecation/migration solution and clearly document the change for 
existing users if we make this change.

Prefixed uomId fields are mostly present when there are other uomId fields in 
the same entity which makes it neccessary to have different names. That's not 
an valid argument for the proposed changed.

> InvoiceItem: uomID is wrongly defined
> -------------------------------------
>
>                 Key: OFBIZ-11431
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11431
>             Project: OFBiz
>          Issue Type: Bug
>          Components: datamodel
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Priority: Critical
>              Labels: refactoring
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently the InvoiceItem entity has the field uomId, per:
> {code:java}
>       <field name="uomId" type="id"></field>
> {code}
> per the demo data this field is used to capture the currency of the invoice 
> item. This is, however, wrong. The currency for invoice items is set in the 
> invoice entity record (with field currencyUomId. 
> The uomId in the invoice item is related to the quantity set, and must be 
> correctly named: 'quantityUomId.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to