[ 
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17749265#comment-17749265
 ] 

Jacques Le Roux commented on OFBIZ-12813:
-----------------------------------------

Hi Michael,

I have applied both patches and all works as expected (lazy tests, but 
cumulative)

> Refactor groovy folder structure and add package declaration
> ------------------------------------------------------------
>
>                 Key: OFBIZ-12813
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12813
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: 22.01.01, Upcoming Branch
>            Reporter: Wiebke Paetzold
>            Assignee: Michael Brohl
>            Priority: Major
>             Fix For: Upcoming Branch
>
>
> Due to the upgrade to jdk17 all groovy Classes need a package declaration. 
> To get a distinct package naming a consistent folder structure is needed.
> For example, under framework -> base -> src there is a distinction between 
> main and test. Within the test folder there is again a distinction between 
> groovy and Java.
> This scheme should be applied everywhere. So a src folder contains main, 
> test, ... within these folders there is again a distinction between groovy 
> and java.
>  
> For more information visit:
> [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages]
> “The Java Platform Module System requires that classes in distinct modules 
> have distinct package names. Groovy has its own "modules" but these haven’t 
> historically been structured according to the above requirement. For this 
> reason, Groovy 2.x and 3.0 should be added to the classpath not module path 
> when using JDK9+. This places Groovy’s classes into the unnamed module where 
> the split package naming requirement is not enforced.“



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to