[ 
https://issues.apache.org/jira/browse/OFBIZ-12789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803260#comment-17803260
 ] 

Jacques Le Roux commented on OFBIZ-12789:
-----------------------------------------

Hi Daniel,

I had a look at 
https://sonarcloud.io/project/issues?resolved=false&types=BUG&id=apache_ofbiz-framework
There is now only 2 issues in jquery.Jcrop.css that don't seem big. Should we 
not neglect and close here?

> Explore further use of npm modules to reduce bugs reported by sonarcloud
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-12789
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12789
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: themes
>    Affects Versions: Upcoming Branch
>            Reporter: Daniel Watford
>            Assignee: Daniel Watford
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>
> Sonarcloud reports 10 bugs in ofbiz sources:
> [https://sonarcloud.io/project/issues?resolved=false&types=BUG&id=apache_ofbiz-framework]
> We tend to only notice bugs in new code as they will be highlighted during 
> pull request checking.
> The majority of these bugs are related to javascript/css files under 
> themes/common-theme/webapp/common-theme not authored by the OFBiz project.
> Explore whether suitable replacements are available for these files as npm 
> modules. If so, remove those files from ofbiz-framework and replace with a 
> corresponding dependency in 
> themes/common-theme/webapp/common-theme/js/package.json.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to