[
https://issues.apache.org/jira/browse/OFBIZ-12789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803271#comment-17803271
]
Daniel Watford commented on OFBIZ-12789:
----------------------------------------
I'm happy to see this ticket closed since I think - back when I last worked on
this - I had probably gone as far as I could with replacing javascript code not
authored by the ofbiz project with npm modules.
Even if we close this ticket, it would be good to have another ticket created
addressing the outstanding sonarcloud issue, even if the fix is to alter the
code in the ofbiz-framework repository.
> Explore further use of npm modules to reduce bugs reported by sonarcloud
> ------------------------------------------------------------------------
>
> Key: OFBIZ-12789
> URL: https://issues.apache.org/jira/browse/OFBIZ-12789
> Project: OFBiz
> Issue Type: Improvement
> Components: themes
> Affects Versions: Upcoming Branch
> Reporter: Daniel Watford
> Assignee: Daniel Watford
> Priority: Minor
> Fix For: Upcoming Branch
>
>
> Sonarcloud reports 10 bugs in ofbiz sources:
> [https://sonarcloud.io/project/issues?resolved=false&types=BUG&id=apache_ofbiz-framework]
> We tend to only notice bugs in new code as they will be highlighted during
> pull request checking.
> The majority of these bugs are related to javascript/css files under
> themes/common-theme/webapp/common-theme not authored by the OFBiz project.
> Explore whether suitable replacements are available for these files as npm
> modules. If so, remove those files from ofbiz-framework and replace with a
> corresponding dependency in
> themes/common-theme/webapp/common-theme/js/package.json.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
