gtchaboussie commented on PR #916:
URL: https://github.com/apache/ofbiz-framework/pull/916#issuecomment-3611443759
Feedback on what was done in the task, and while re-writing
- I enabled the JUnit4 tests in gradle (that's debatable, but allows for the
removal of all groovy test files to be run during tests)
- After concertation with Nicolas, removed the GenericTestBaseCase, that
wasn't in framework or plugins
- I migrated the cache tests in groovy
- I separated the actuel tests from the differents utility methods and
objects (and put them in a separated file)
- I removed the hamcrest dependency to use the vanilla groovy assertion
- I exploded the `basicTest` test method, and rewrote several test following
the standard CRUD operations.
- I cleaned some of the assertions that were made in some of the tests
- For example, i couldn't see the point of comparing two newly
instanciated lists
- Merged the part of `basicTest` related to expiration with the `expireTest`
Obsiously, all of the above is open to discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
