gtchaboussie commented on PR #916: URL: https://github.com/apache/ofbiz-framework/pull/916#issuecomment-3617334230
After some resarch, here is my analysis. The following tests were explicitly added to groovy sources. ```groovy include 'org/apache/ofbiz/service/ModelServiceTest.groovy' include 'org/apache/ofbiz/test/TestServices.groovy' include 'org/apache/ofbiz/base/util/string/FlexibleStringExpanderBaseCodeTests.groovy' include 'org/apache/ofbiz/base/util/FileUtilTests.groovy' include 'org/apache/ofbiz/service/test/ServicePurgeTest.groovy' include 'org.apache.ofbiz.base.test.SimpleTests.groovy' ``` ModelServiceTest.groovy, FlexibleStringExpanderBaseCodeTests.groovy, and FileUtilTests.groovy are indeed unit tests, and already are in relevant test sources. With junit enabled in build.gradle, they run and don't need the explicit declaration. So they are ok. TestServices.groovy is a groovy service file, and doesn't contain any test. It was most likely added by mistake. As for ServicePurgeTest.groovy and SimpleTests.groovy, they look like integration tests. They depend on the GroovyAssert class, that uses Junit5 indeed. But they don't need to be treated as source. As it is in trunk, they are not run though. The declaration of both test suits has been deleted, and is not in any component anymore. I suggest reenableing these tests in appropriate components (commented for now until they are validated) and keeping the simple junit architecture. We can create an other task to sort out ServicePurgeTest.groovy and SimpleTests.groovy. By the way, @JacquesLeRoux , do you remember the reason behind [this](https://github.com/apache/ofbiz-framework/commit/f8ad232565558c07c176985d25ac4a0b66608e59) commit that removed the test declaration ? I'm not sure I understand why ServicePurgeTest.groovy and SimpleTests.groovy wouldn't be integration tests anymore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
