mdedetrich commented on code in PR #333:
URL:
https://github.com/apache/incubator-pekko-http/pull/333#discussion_r1375408931
##########
project/PekkoDependency.scala:
##########
@@ -114,11 +116,12 @@ object PekkoDependency {
ep.toInt,
maj.toInt,
min.toInt,
- Option(tagNumber).map(_.toInt),
+ Option(tagNumber).map(_.toInt).getOrElse(Integer.MAX_VALUE),
Review Comment:
Oh nvm, its for ordering and not the actual value. @pjfanning Can you just
add a comment explaining that its there to fix ordering and then ill approve PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
