pjfanning commented on code in PR #333:
URL:
https://github.com/apache/incubator-pekko-http/pull/333#discussion_r1375409304
##########
project/PekkoDependency.scala:
##########
@@ -114,11 +116,12 @@ object PekkoDependency {
ep.toInt,
maj.toInt,
min.toInt,
- Option(tagNumber).map(_.toInt),
+ Option(tagNumber).map(_.toInt).getOrElse(Integer.MAX_VALUE),
Review Comment:
The values are used only in sorting.
* `-RC1-` will eval as 1
* no `-RC` or `-M` will now eval as MAX-INT
* MAX-INT > 1 so sorting will treat non-RC/non-milestone releases as newer
Old logic:
* `-RC1-` will eval as `Some(1)`
* no `-RC` or `-M` will eval as `None`
* `None` < `Some(1)` so sorting will treat non-RC/non-milestone releases as
older
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
