pjfanning commented on code in PR #218: URL: https://github.com/apache/pekko-management/pull/218#discussion_r1589620423
########## lease-kubernetes-int-test/src/main/scala/org/apache/pekko/coordination/lease/kubernetes/LeaseSpec.scala: ########## @@ -16,7 +16,7 @@ package org.apache.pekko.coordination.lease.kubernetes import org.apache.pekko import pekko.actor.ActorSystem import pekko.coordination.lease.TimeoutSettings -import pekko.coordination.lease.kubernetes.internal.KubernetesApiImpl +import pekko.coordination.lease.kubernetes.internal.CRDKubernetesApiImpl Review Comment: -1 to the class rename Like it or not, we cannot just rename classes or repurpose existing classes to do something else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
