pjfanning commented on code in PR #218:
URL: https://github.com/apache/pekko-management/pull/218#discussion_r1589799959
##########
lease-kubernetes/src/main/scala/org/apache/pekko/coordination/lease/kubernetes/internal/KubernetesJsonSupport.scala:
##########
@@ -38,14 +38,32 @@ case class Metadata(name: String, resourceVersion:
Option[String])
* INTERNAL API
*/
@InternalApi
-case class Spec(owner: String, time: Long)
+case class CustomSpec(owner: String, time: Long)
+
+/**
+ * INTERNAL API
+ */
+@InternalApi
+case class NativeLeaseResource(
+ metadata: Metadata,
+ spec: NativeSpec,
+ kind: String = "Lease",
+ apiVersion: String = "coordination.k8s.io/v1")
+
+/**
+ * INTERNAL API
+ */
+@InternalApi
+case class NativeSpec(holderIdentity: String, acquireTime: String)
/**
* INTERNAL API
*/
@InternalApi
trait KubernetesJsonSupport extends SprayJsonSupport with DefaultJsonProtocol {
implicit val metadataFormat: JsonFormat[Metadata] =
jsonFormat2(Metadata.apply)
- implicit val specFormat: JsonFormat[Spec] = jsonFormat2(Spec.apply)
+ implicit val customSpecFormat: JsonFormat[CustomSpec] =
jsonFormat2(CustomSpec.apply)
Review Comment:
again - don't rename existing classes or fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
