pjfanning commented on code in PR #630:
URL: https://github.com/apache/pekko-http/pull/630#discussion_r1843768464
##########
http-core/src/main/scala/org/apache/pekko/http/javadsl/model/ContentType.scala:
##########
@@ -61,4 +61,9 @@ trait ContentType {
* Returns the charset if this ContentType is non-binary.
*/
def getCharsetOption: Optional[HttpCharset]
+
+ /**
+ * Returns the string representation of this ContentType
+ */
Review Comment:
I think it is too disruptive to release a 1.2.0 release just for 2 new
functions. It would be better to wait a few months to see if we gather a few
changes.
I am flexible about adding small API changes that have low impact in a patch
release. The only users who would be seriously affected by this are users who
subclass the 2 affected traits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
