pjfanning commented on code in PR #630:
URL: https://github.com/apache/pekko-http/pull/630#discussion_r1844210638
##########
http-core/src/main/scala/org/apache/pekko/http/javadsl/model/ContentType.scala:
##########
@@ -61,4 +61,10 @@ trait ContentType {
* Returns the charset if this ContentType is non-binary.
*/
def getCharsetOption: Optional[HttpCharset]
+
+ /**
+ * Returns the string representation of this ContentType
+ * @since 1.2.0
+ */
+ def value: String
}
Review Comment:
I think this should be getValue. More Java API like. Other existing methods
seem to be getters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
