mdedetrich commented on code in PR #630:
URL: https://github.com/apache/pekko-http/pull/630#discussion_r1860372702


##########
http-core/src/main/mima-filters/1.2.x.backwards.excludes/content-media-type-value-string.backwards.excludes:
##########
@@ -0,0 +1,2 @@
+ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.pekko.http.javadsl.model.ContentType.value")
+ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.pekko.http.javadsl.model.MediaType.value")

Review Comment:
   No thats fair, I thought you were talking about `ValueRenderable` but that 
wouldn't make sense its already marked as `@InternalApi`.
   
   We can remove and also fix the Java namings (i.e. `value` should be 
`getValue`) as well as removing `@DoNotInherit` in 2.x.x



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to