raboof commented on PR #630: URL: https://github.com/apache/pekko-http/pull/630#issuecomment-2503867626
> > > > > We still need to block the merge until we have the 1.1.x branch and related CI builds. > > > > > > > > > > > > I think I missed why we'd want to delay this merge - this PR as it now stands seems like a regular backwards-compatible change (assuming nobody inherited from `ContentType` or `MediaType`, which seems like a reasonable assumption)? > > > > > > > > > The PR currently has `@since 1.2.0`. If these change to `@since 1.1.1` then we don't need to start preparing for 1.2.0 snapshots. > > > > > > Aah, gotcha. This begs the question whether those `@since` annotations are really worth having. I can easily imagine situations where it isn't clear yet whether the next release will be a minor, patch or major one. Should/have we discuss(ed) this on the mailinglist? > > I guess we can discuss the philosophies around using since annotations on the mailing list OK, I can start that thread. > I would strongly argue that we can't change the established approach in a patch release. OK. AFAICS the 1.1.x branch has already been created, meaning the `@since 1.2.0` is correct, right? Is there anything that still needs to be done before #631 can be un-drafted and merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
