pjfanning commented on code in PR #1578:
URL: https://github.com/apache/pekko/pull/1578#discussion_r1877706957
##########
cluster/src/test/scala/org/apache/pekko/cluster/protobuf/ClusterMessageSerializerSpec.scala:
##########
@@ -177,6 +177,14 @@ class ClusterMessageSerializerSpec extends
PekkoSpec("pekko.actor.provider = clu
ClusterMessageSerializer.OldWelcomeManifest)
}
+ "be de-serializable with class manifests from Akka nodes" in {
+ val oldAkkaJoinAckManifest =
s"org.apache.pekko.cluster.InternalClusterAction$$InitJoinAck"
Review Comment:
@sadekmunawar this class only needs to be supported for Akka prior to v2.6.4.
Do we really need to support clusters that are running with very old Akka
releases? Ideally we would only support pretty recent Akka releases. It is a
pity that Akka changed the cluster messages in a patch release (2.6.5).
https://github.com/apache/pekko/blob/5d4e8283c3b530cdec56357d0f5f3bfb50effbfd/cluster/src/main/scala/org/apache/pekko/cluster/protobuf/ClusterMessageSerializer.scala#L44-L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
