pjfanning commented on code in PR #1578:
URL: https://github.com/apache/pekko/pull/1578#discussion_r1877604121
##########
cluster/src/test/scala/org/apache/pekko/cluster/protobuf/ClusterMessageSerializerSpec.scala:
##########
@@ -177,6 +177,14 @@ class ClusterMessageSerializerSpec extends
PekkoSpec("pekko.actor.provider = clu
ClusterMessageSerializer.OldWelcomeManifest)
}
+ "be de-serializable with class manifests from Akka nodes" in {
+ val oldAkkaJoinAckManifest =
s"org.apache.pekko.cluster.InternalClusterAction$$InitJoinAck"
Review Comment:
`s""` interpolation is not needed here
##########
cluster/src/test/scala/org/apache/pekko/cluster/protobuf/ClusterMessageSerializerSpec.scala:
##########
@@ -177,6 +177,14 @@ class ClusterMessageSerializerSpec extends
PekkoSpec("pekko.actor.provider = clu
ClusterMessageSerializer.OldWelcomeManifest)
}
+ "be de-serializable with class manifests from Akka nodes" in {
Review Comment:
deserializable as opposed to de-serializable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
