pjfanning commented on code in PR #809:
URL: https://github.com/apache/pekko-http/pull/809#discussion_r2395537969
##########
http-core/src/main/scala/org/apache/pekko/http/impl/model/parser/CommonActions.scala:
##########
@@ -80,7 +80,7 @@ private[parser] trait CommonActions {
val char2 = str2.charAt(at)
(char1 | char2) < 0x80 &&
- Character.toLowerCase(char1) == Character.toLowerCase(char2) &&
+ CharUtils.toLowerCase(char1) == CharUtils.toLowerCase(char2) &&
Review Comment:
Actually, in hindsight, this might be the riskiest change.
CharUtils.toLowerCase only lower cases the 26 standard letters of the latin
alphabet (the ones in 7 bit ASCII table) while java.lang.Character.toLowerCase
seems to support other letters that appear in Unicode table. Let me re-review
this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
