raboof commented on code in PR #809:
URL: https://github.com/apache/pekko-http/pull/809#discussion_r2395128578
##########
http-core/src/main/scala/org/apache/pekko/http/impl/model/parser/CommonActions.scala:
##########
@@ -80,7 +80,7 @@ private[parser] trait CommonActions {
val char2 = str2.charAt(at)
(char1 | char2) < 0x80 &&
- Character.toLowerCase(char1) == Character.toLowerCase(char2) &&
+ CharUtils.toLowerCase(char1) == CharUtils.toLowerCase(char2) &&
Review Comment:
👍 clearly safe
##########
http-core/src/main/scala/org/apache/pekko/http/impl/model/parser/UriParser.scala:
##########
@@ -365,7 +365,7 @@ private[http] final class UriParser(
///////////// helpers /////////////
- private def appendLowered(): Rule0 = rule {
run(sb.append(CharUtils.toLowerCase(lastChar))) }
+ private def appendLowered(): Rule0 = rule {
run(sb.append(CU.toLowerCase(lastChar))) }
Review Comment:
can we assume `lastChar` is 7-bit ascii here? or are we OK with letting
other characters through?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
