raboof commented on PR #2486: URL: https://github.com/apache/pekko/pull/2486#issuecomment-3522645546
> `close` is blocking and returns `Unit`/`Void` Is there a requirement for close to block until the closing is 'complete'? > The PR also cleans up test code by removing the `Await.result(system.close,...)` pattern that is used everywhere. I can see the appeal, though blocking is a bit 'uncharacteristic' for us. I guess because you're stopping the ActorSystem and thus are anyway 'on your way out' it might be fine? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
