mdedetrich commented on PR #2486: URL: https://github.com/apache/pekko/pull/2486#issuecomment-3524088728
> Does this PR also need to update [ActorSystemLifecycle.scala#L54](https://github.com/apache/pekko/blob/main/stream-tests-tck/src/test/scala/org/apache/pekko/stream/tck/ActorSystemLifecycle.scala#L54)? So for this I would need an overloaded version of close with a duration i.e. `close(duration)` and that version would come after creating a `scaladsl/`javadsl` for `ActorSystem` since the `javadsl` will use a java duration and the `scaladsl` will use a scala duration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
