raboof commented on code in PR #2409:
URL: https://github.com/apache/pekko/pull/2409#discussion_r2560585971
##########
.scala-steward.conf:
##########
@@ -5,6 +5,8 @@ updates.pin = [
{ groupId = "org.scala-lang", artifactId = "scala3-library", version =
"3.3." }
# sbt-assembly 2.3 causes build issues
(https://github.com/apache/pekko/pull/1744)
{ groupId = "com.eed3si9n", artifactId = "sbt-assembly", version = "2.2." }
+ # zstd-jni upgrades are fine as long as they are backwards compatible
+ { groupId = "com.github.luben", artifactId = "zstd-jni", version = "1."}
Review Comment:
It _could_, but it's not _necessarily_ problematic. We specifically reserve
the right to do major version updates of dependencies when we deem them
unproblematic
(https://pekko.apache.org/docs/pekko/current/common/binary-compatibility-rules.html#binary-compatibility-of-dependencies).
We let scala-steward open PRs for such upgrades, and then when that happens we
can decide whether to follow upstream or restrict ourselves to the previous
major version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
