mdedetrich commented on code in PR #2409: URL: https://github.com/apache/pekko/pull/2409#discussion_r2576984917
########## actor/src/main/java/org/apache/pekko/io/ByteBufferCleaner.java: ########## @@ -36,7 +37,8 @@ * * <p>See <a href=https://bugs.openjdk.java.net/browse/JDK-4724038>JDK-4724038</a> */ -final class ByteBufferCleaner { +@InternalStableApi Review Comment: > Are you planning to use this API in other Pekko modules? If not then we can remove this annotation here. If so then we should add a note to the scaladoc pointing to where it's (going to be) used. As you allude to, the reason why I added `@InternalStableApi` is that I can imagine cases where other Pekko libraries (i.e. pekko-http or even pekko-connectors) might want to use `ByteBufferCleaner` and obviously this would need to be available in the Pekko 2.0.0 release to fullfil this. Also this API is quite stable, hence why I added `@InternalStableApi`, but yes in general it was a forward thinking rationality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
