Luka-J9 commented on code in PR #1246:
URL: https://github.com/apache/pekko-connectors/pull/1246#discussion_r2565156296
##########
s3/src/main/scala/org/apache/pekko/stream/connectors/s3/settings.scala:
##########
@@ -420,6 +427,17 @@ final class S3Settings private (
def withSignAnonymousRequests(value: Boolean): S3Settings =
if (signAnonymousRequests == value) this else copy(signAnonymousRequests =
value)
+ private[s3] val concreateAllowedHeaders: Map[S3Request, Set[String]] = {
+ allowedHeaders.foldLeft(Map.empty[S3Request, Set[String]]) {
+ case (acc, (header, value)) =>
+ S3Request.fromString(header) match {
+ case OptionVal.Some(header) => acc + (header -> value)
+ case OptionVal.None => acc
+ case other => throw new MatchError(other)
Review Comment:
This isn't valid - additionally other parts of code does it this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
