pjfanning commented on code in PR #1246:
URL: https://github.com/apache/pekko-connectors/pull/1246#discussion_r2565530593
##########
s3/src/main/scala/org/apache/pekko/stream/connectors/s3/settings.scala:
##########
@@ -13,25 +13,30 @@
package org.apache.pekko.stream.connectors.s3
-import java.nio.file.{ Path, Paths }
-import java.time.{ Duration => JavaDuration }
-import java.util.concurrent.TimeUnit
-import java.util.{ Objects, Optional }
-
-import org.apache.pekko
-import pekko.actor.{ ActorSystem, ClassicActorSystemProvider }
-import pekko.http.scaladsl.model.Uri
-import pekko.stream.connectors.s3.AccessStyle.{ PathAccessStyle,
VirtualHostAccessStyle }
import com.typesafe.config.Config
+import org.apache.pekko
+import org.apache.pekko.stream.connectors.s3.impl.S3Request
Review Comment:
If you import org.apache.pekko, then can omit the org.apache bit in later
pekko imports. This is preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
